Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

romio/daos: better conditionals to build with libdaos.so.0/1 #45

Open
wants to merge 1 commit into
base: daos_adio-rpm
Choose a base branch
from

Conversation

kccain
Copy link

@kccain kccain commented Jan 6, 2021

Enhance the conditional compilation logic in the daos adio
driver for compiling against libdaos.so.0 (old API) that does not
provide a DAOS_API_MAJOR_VERSION preprocessor macro.

Signed-off-by: Kenneth Cain [email protected]

Pull Request Description

Expected Impact

Author Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Remove xfail from the test suite when fixing a test
  • Commits are self-contained and do not do two things at once
  • Commit message is of the form: module: short description and follows good practice
  • Passes whitespace checkers
  • Passes warning tests
  • Passes all tests
  • Add comments such that someone without knowledge of the code could understand
  • You or your company has a signed contributor's agreement on file with Argonne
  • For non-Argonne authors, request an explicit comment from your companies PR approval manager

Enhance the conditional compilation logic in the daos adio
driver for compiling against libdaos.so.0 (old API) that does not
provide a DAOS_API_MAJOR_VERSION preprocessor macro.

Signed-off-by: Kenneth Cain <[email protected]>
@kccain
Copy link
Author

kccain commented Jan 6, 2021

It is TBD if this PR will be landed. Or if instead, the code changes may simply be included in PR 44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant