Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

Upgrade pallet-faucets to FRAME v2 #214

Closed
wants to merge 5 commits into from
Closed

Upgrade pallet-faucets to FRAME v2 #214

wants to merge 5 commits into from

Conversation

Doordashcon
Copy link

@Doordashcon Doordashcon commented May 3, 2022

TODO

  • Lib
  • Mock
  • Test
  • Documentation
  • Benchmarks

@Doordashcon Doordashcon changed the title chore: Upgrade pallet-faucet chore: Upgrade pallet-faucet May 3, 2022
@Doordashcon
Copy link
Author

tbh i think this pallet needs a change, for one the ability to create a new faucet should be possible through a helper function cc @siman

@F3Joule F3Joule added the enhancement New feature or request label May 4, 2022
@F3Joule F3Joule changed the title chore: Upgrade pallet-faucet Upgrade pallet-faucets to FRAME v2 May 4, 2022
@F3Joule
Copy link
Member

F3Joule commented May 4, 2022

tbh i think this pallet needs a change, for one the ability to create a new faucet should be possible through a helper function cc @siman

I see it like: we have a common function, but 2 different dispatch calls: force_add_faucet, add_faucet. The last one can create a faucet from caller account. The force one can create a faucet from any account, but caller should be root.

@Doordashcon
Copy link
Author

@F3Joule currently add_faucet dispatch can only be called by root and accepts an accountId, force_add_faucet does not exist.

@F3Joule
Copy link
Member

F3Joule commented May 5, 2022

@F3Joule currently add_faucet dispatch can only be called by root and accepts an accountId, force_add_faucet does not exist.

I mean, imo, we should do like I've described.

@Doordashcon Doordashcon marked this pull request as ready for review May 8, 2022 13:31
@Doordashcon
Copy link
Author

Doordashcon commented May 8, 2022

@F3Joule Do we have a specific spec machine for producing weights?

@Doordashcon
Copy link
Author

Doordashcon commented May 14, 2022

Hi @F3Joule Are the changes acceptable? I want to work on other pallets

@Doordashcon Doordashcon closed this Jun 6, 2022
@Doordashcon Doordashcon deleted the ddc-RFP-T1 branch June 6, 2022 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants