Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dapp: Gas snapshotting #850

Merged
merged 14 commits into from
Nov 11, 2021
Merged

dapp: Gas snapshotting #850

merged 14 commits into from
Nov 11, 2021

Conversation

transmissions11
Copy link
Contributor

@transmissions11 transmissions11 commented Oct 30, 2021 •
edited
Loading

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

jennypollack
jennypollack approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@jennypollack jennypollack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-xo
Copy link
Contributor

d-xo commented Nov 9, 2021

fine with this in general, would be great to have a test though, perhaps something structured in a similar way to test_custom_solc_json?

@transmissions11
Copy link
Contributor Author

fine with this in general, would be great to have a test though, perhaps something structured in a similar way to test_custom_solc_json?

done!

@jennypollack jennypollack merged commit 0cad2d2 into dapphub:master Nov 11, 2021
@transmissions11 transmissions11 deleted the gas-snapshot-dev branch November 11, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypollack jennypollack jennypollack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@transmissions11 @d-xo @jennypollack