Fix error handling

dappnode · Apr 27, 2023 · 364356c · 364356c
1 parent c34a133
commit 364356c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 18 deletions.
diff --git a/src/certificates/apiSign.ts b/src/certificates/apiSign.ts
@@ -4,18 +4,14 @@ import axios from "axios";
 import shell from "../utils/shell";
 
 async function getEthSignature(timestamp: number): Promise<[string, string]> {
-  try {
-    const response = await axios.post(
-      process.env.DAPPMANAGER_SIGN,
-      timestamp.toString(),
-      {
-        headers: { "Content-Type": "text/plain" },
-      }
-    );
-    return [response.data.signature, response.data.address];
-  } catch (e) {
-    console.warn(e);
-  }
+  const response = await axios.post(
+    process.env.DAPPMANAGER_SIGN,
+    timestamp.toString(),
+    {
+      headers: { "Content-Type": "text/plain" },
+    }
+  );
+  return [response.data.signature, response.data.address];
 }
 
 async function executeAPISign(

diff --git a/src/certificates/index.ts b/src/certificates/index.ts
@@ -10,11 +10,7 @@ import {
 
 export async function ensureValidCert(createIfNotExists = false) {
   if (await shouldRenew(createIfNotExists)) {
-    try {
-      await signCert();
-    } catch (e) {
-      console.log(e);
-    }
+    await signCert();
   } else {
     console.log("Certificate valid or not necessary, skip signing");
   }
@@ -37,7 +33,13 @@ export default async function initCertificateProvider() {
   }
 
   console.log("Setting cronjob for cert updates");
-  setInterval(ensureValidCert, config.certCheckInterval);
+  setInterval(async () => {
+    try {
+      await ensureValidCert();
+    } catch (e) {
+      console.warn(e);
+    }
+  }, config.certCheckInterval);
 }
 
 async function signCert() {