Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and grammar, add link to github issues to fix broken report link in adminUI, bump ruby version to v2.7.5 #57

Merged
merged 5 commits into from
Dec 7, 2021

Conversation

alexpeterson91
Copy link
Member

@alexpeterson91 alexpeterson91 commented Dec 6, 2021

Fixed a few misspelled words, and added several "the"s to make the sentences flow better in English, and fixed some other minor grammar.

Fixed a few misspelled words, and added several "the"s to make the sentences flow better in English, and fixed some other minor grammar.


Note:
i did not fix this sentence yet since I'm not certain what it means exactly but again i think it just needs a "the" somewhere to make it totally clear will update when I've spoken to someone to clarify.
`But please note, for every subdomain certificate is requested since it uses HTTP challenges which cannot be used for issuing wildcard certificates.`
Moved license up like most other dappnode_package.JSONs
and added link to this repo's Issues to fix the broken report link in the adminUI
@alexpeterson91 alexpeterson91 changed the title Fix typos and grammar Fix typos and grammar, add link to github issues to fix broken report link in adminUI Dec 7, 2021
Logo for the HTTPS logo was titled as "DAPPMANAGER" so i changed it to "HTTPS"
@dapplion dapplion requested review from 3alpha and tropicar December 7, 2021 07:29
@3alpha
Copy link
Member

3alpha commented Dec 7, 2021

In Dockerfile please change line 1 to:
FROM ruby:2.7.5-alpine AS ruby-builder
and line 53 to:
python2 ruby=2.7.5-r0 iproute2 apache2-utils logrotate openssl \
That way CI will pass.

Bumped ruby version per @3alpha to allow CI to build successfully
@alexpeterson91 alexpeterson91 changed the title Fix typos and grammar, add link to github issues to fix broken report link in adminUI Fix typos and grammar, add link to github issues to fix broken report link in adminUI, bump ruby version Dec 7, 2021
@alexpeterson91 alexpeterson91 changed the title Fix typos and grammar, add link to github issues to fix broken report link in adminUI, bump ruby version Fix typos and grammar, add link to github issues to fix broken report link in adminUI, bump ruby version to v2.7.5 Dec 7, 2021
added an "a" to make the sentence flow properly and make sense
@3alpha 3alpha merged commit dfaae72 into dappnode:master Dec 7, 2021
@alexpeterson91 alexpeterson91 deleted the patch-1 branch December 9, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants