Move local domain to environment #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: 65fbdec This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
dapplion
approved these changes
Mar 18, 2022
|
Tested and it works. It is important to note that this environment value should not be changed manually (yet) since DAppManager publishes only |
|
@3alpha Could you link to an issue or PR on the dappmanager that actually uses this? |
|
It will be needed in the future, DAppManager Issue is linked above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extacting local domain to environment so in it can be configured directly from DAppManager