Fix empty dappnode domain #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablomendezroyo
requested changes
Jun 30, 2023
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: 6f5f7fd This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
pablomendezroyo
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like sometimes dappmanager is not able to inject the env
_DAPPNODE_GLOBAL_DOMAINinto the HTTPS package, probably because the dappmanager is not properly running at the time HTTPS is started. In order to avoid this, if the env is empty, the package will try to retrieve this from the dappmanager API.