Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dapr support for Redis 7 in cluster mode #1909

Closed
thielepaul opened this issue Jul 25, 2022 · 2 comments · Fixed by #2228
Closed

Add Dapr support for Redis 7 in cluster mode #1909

thielepaul opened this issue Jul 25, 2022 · 2 comments · Fixed by #2228
Assignees
Labels
kind/enhancement New feature or request P1 pinned Issue does not get stale
Milestone

Comments

@thielepaul
Copy link
Contributor

Expected Behavior

I expect dapr to connect to the latest version of redis.

Actual Behavior

When I connect to a redis instance deployed to kubernetes, I get the following error:

time="2022-07-25T14:55:59.411020038Z" level=fatal msg="process component statestore error: redis store: error connecting to redis at state-store-redis-cluster:6379: got 4 elements in cluster info address, expected 2 or 3" app_id=subscriber instance=subscriber-deployment-68b65fd66b-tp6tc scope=dapr.runtime type=log ver=1.7.2

Steps to Reproduce the Problem

It seems we should use github.com/go-redis/redis/v9 to support redis 7: redis/go-redis#2085 (comment)

As you can see in the log message I am currently using dapr 1.7.2, but it seems the bug is also in the current master: https://github.com/dapr/components-contrib/blob/master/go.mod#L65

Release Note

RELEASE NOTE:

@thielepaul thielepaul added the kind/bug Something isn't working label Jul 25, 2022
@yaron2
Copy link
Member

yaron2 commented Jul 25, 2022

Thanks, would you like to create a PR that updates go.mod to the v9 version?

@yaron2 yaron2 added this to the v1.9 milestone Jul 25, 2022
@thielepaul
Copy link
Contributor Author

I just hat a short look on that, and it seems it is more complicated than just updating the dependency:

If you are using Redis 6, install go-redis/v8
If you are using Redis 7, install go-redis/v9
(https://github.com/go-redis/redis#installation)

Probably, it would make sense to have the redis version configurable in the component specification and then use go-redis/redis/v8 or go-redis/redis/v9 depending on what is selected there.

Thanks, would you like to create a PR that updates go.mod to the v9 version?

I'm sorry, but I currently don't have the time to do this and using redis 6 for the time being is also not an issue for us.

@artursouza artursouza added P1 pinned Issue does not get stale good first issue Good for newcomers labels Jul 28, 2022
@berndverst berndverst modified the milestones: v1.9, v1.10 Sep 15, 2022
@berndverst berndverst modified the milestones: v1.10, v1.9 Sep 15, 2022
@artursouza artursouza modified the milestones: v1.9, v1.10 Sep 29, 2022
@berndverst berndverst assigned berndverst and unassigned yaron2 Nov 2, 2022
@berndverst berndverst added kind/enhancement New feature or request and removed good first issue Good for newcomers kind/bug Something isn't working labels Nov 2, 2022
@berndverst berndverst changed the title Dapr is incompatible with redis 7 in cluster mode Add Dapr support for Redis 7 in cluster mode Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request P1 pinned Issue does not get stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants