Adds support for Redis 7 via redisVersion metadata in all redis components
#2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
- Coverage 37.86% 37.52% -0.34%
==========================================
Files 193 193
Lines 24554 24721 +167
==========================================
- Hits 9297 9277 -20
- Misses 14543 14663 +120
- Partials 714 781 +67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Bernd Verst <[email protected]>
|
More work needed to make certification tests pass. |
artursouza
reviewed
Sep 19, 2022
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| r.ctx, r.cancel = context.WithCancel(context.Background()) | ||
|
|
||
| _, err = r.client.Ping(r.ctx).Result() | ||
| if r.legacyRedis { | ||
| _, err = r.clientv8.Ping(r.ctx).Result() |
There was a problem hiding this comment.
Is there a way to use Go lang to avoid these if checks? Could we declare an interface containing the methods we use here and declare a reference to that? Then, the only difference would be which instanced is referenced but they would both implement the same interface.
Signed-off-by: Bernd Verst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Redis 7 via
redisVersionmetadata in all redis componentsWhen setting
redisVersionto7/v7or greater the new Redis Go SDK v9 will be used. For Redis 6 and below the v8 SDK will be used.Issue reference
#1909
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: