Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secret store: AWS connection validation for parameter store and secrets manager #3301

Merged
merged 12 commits into from
Jan 16, 2024
Merged

secret store: AWS connection validation for parameter store and secrets manager #3301

merged 12 commits into from
Jan 16, 2024

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Jan 3, 2024 •
edited
Loading

Description

This PR adds AWS connection validation on dapr init for:

  • Secret Store: parameter store
  • Secret Store: secrets manager

Issue reference

#3190

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation - N/A

@elena-kolevska elena-kolevska mentioned this pull request Jan 3, 2024
Closed
@elena-kolevska
Linter
7dbe311 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
Typo
4650cb8 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
removing the rand test as it’s not really meaningful and the linter c…
a5d80b1 
…omplains against using math/rand

Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska changed the title AWS connection validation secret store: AWS connection validation for parameter store and secrets manager Jan 8, 2024
@elena-kolevska elena-kolevska marked this pull request as ready for review January 8, 2024 11:54
@elena-kolevska elena-kolevska requested review from a team as code owners January 8, 2024 11:54
elena-kolevska and others added 3 commits January 8, 2024 13:51
@elena-kolevska
Fix linter complaint
2a7f480 
Signed-off-by: Elena Kolevska <[email protected]>
@ItalyPaleAle
Merge branch 'main' into aws
ee1e6d9
@ItalyPaleAle
💄
d8b9059 
Signed-off-by: ItalyPaleAle <[email protected]>
@ItalyPaleAle ItalyPaleAle added this to the v1.13 milestone Jan 16, 2024
@ItalyPaleAle ItalyPaleAle added this pull request to the merge queue Jan 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2024
@ItalyPaleAle ItalyPaleAle merged commit 353447c into dapr:main Jan 16, 2024
88 checks passed
@elena-kolevska
Copy link
Contributor Author

Thanks @ItalyPaleAle :)

toneill818 pushed a commit to toneill818/components-contrib that referenced this pull request Jan 22, 2024
@elena-kolevska @ItalyPaleAle @toneill-newinnov
secret store: AWS connection validation for parameter store and secre…
d5911ad 
…ts manager (dapr#3301)

Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
Signed-off-by: Thomas O'Neill <[email protected]>
This was referenced Aug 30, 2024
Merged
Merged
@elena-kolevska elena-kolevska deleted the aws branch January 14, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItalyPaleAle ItalyPaleAle ItalyPaleAle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
2 participants
@elena-kolevska @ItalyPaleAle