-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis State Store query: numeric operators do not work correctly on large numbers #3334
Conversation
Signed-off-by: yaron2 <[email protected]> Signed-off-by: Guido Spadotto <[email protected]>
Signed-off-by: Guido Spadotto <[email protected]> Signed-off-by: Guido Spadotto <[email protected]>
Signed-off-by: Guido Spadotto <[email protected]>
I think (haven't investigated too much however) that it's because they come from JSON. In order to stay compatible with JS (where all numbers are floats), the JSON parser uses float64 when parsing numbers into |
Hi @ItalyPaleAle, I have no knowledge of the process by which a given PR is associated to a specific milestone, could this fix be scheduled for v1.13 or - at least - be included in the nightly builds (like this)? My use cases rely on this fix to be in place so I would really appreciate if I could test it as soon as possible. Thanks. |
Sadly we are really past the code freeze date for 1.13, which was many weeks ago. We can, and sometimes do, make exceptions for bugs that are critical - in this case, because state store querying is an alpha feature (with no path to ever become stable), I am afraid it may be too late for 1.13. We can definitely include it in a nightly build. I can pin an updated version of this repo in dapr/dapr so it can start being published. |
@gspadotto buona notizia. I spoke with another maintainer, we are ok cherry-picking this into 1.13. It should be included in the next RC :) |
…arge numbers (dapr#3334) Signed-off-by: Guido Spadotto <[email protected]> Signed-off-by: Guido Spadotto <[email protected]> Co-authored-by: Guido Spadotto <[email protected]>
Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Guido Spadotto <[email protected]> Signed-off-by: Guido Spadotto <[email protected]> Co-authored-by: Guido Spadotto <[email protected]> Co-authored-by: Guido Spadotto <[email protected]>
Description
Applied changes to the formatting of numeric values.
I have no deep knowledge of why all numeric values in the Unit Tests are considered as float, so I changed the unit tests in order to make them pass. (I know this is bad)
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #3332
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: