Azure auth: do not use CLI provider by default when running in a cloud service #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d service This seems to be causing some issues for customers, and in a cloud service the CLI credentials would not work anyways. Signed-off-by: ItalyPaleAle <[email protected]>
|
Looks good to me. |
berndverst
requested changes
Feb 6, 2024
Please look at the diff. This only impacts when running in a cloud service. outside of a cloud service, CLI credentials still work |
berndverst
approved these changes
Feb 6, 2024
berndverst
requested changes
Feb 6, 2024
berndverst
approved these changes
Feb 7, 2024
|
/ok-to-test |
Components certification testCommit ref: 8fed634 ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 8fed634 ✅ All conformance tests passedAll tests have reported a successful status |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 8fed634 |
ItalyPaleAle
added a commit
that referenced
this pull request
Feb 7, 2024
…d service (#3338) Signed-off-by: ItalyPaleAle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be causing some issues for customers, and in a cloud service the CLI credentials would not work anyways.