Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix spelling in two workflows #3462

Merged
merged 1 commit into from
Jun 25, 2024
Merged

ci: fix spelling in two workflows #3462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/certification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ jobs:
run:
shell: bash

needs:
needs:
- generate-matrix

strategy:
fail-fast: false # Keep running even if one component fails
matrix:
matrix:
include: ${{ fromJson(needs.generate-matrix.outputs.test-matrix) }}

steps:
Expand Down Expand Up @@ -254,7 +254,7 @@ jobs:
AWS_REGION: "${{ env.AWS_REGION }}"
run: |
echo "Running certification tests for ${{ matrix.component }} ... "
echo "Source Pacakge: " ${{ matrix.source-pkg }}
echo "Source Package: " ${{ matrix.source-pkg }}
export GOLANG_PROTOBUF_REGISTRATION_CONFLICT=ignore
set +e
gotestsum --jsonfile ${{ env.TEST_OUTPUT_FILE_PREFIX }}_certification.json \
Expand Down Expand Up @@ -334,7 +334,7 @@ jobs:
name: Post-completion
runs-on: ubuntu-22.04
if: always()
needs:
needs:
- certification
- generate-matrix
steps:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/conformance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@ jobs:
run:
shell: bash

needs:
needs:
- generate-matrix

strategy:
fail-fast: false # Keep running even if one component fails
matrix:
matrix:
include: ${{ fromJson(needs.generate-matrix.outputs.test-matrix) }}

steps:
Expand Down Expand Up @@ -267,7 +267,7 @@ jobs:
- name: Run tests
continue-on-error: true
run: |
set -e
set -e
KIND=$(echo ${{ matrix.component }} | cut -d. -f1)
NAME=$(echo ${{ matrix.component }} | cut -d. -f2-)
KIND_UPPER="$(tr '[:lower:]' '[:upper:]' <<< ${KIND:0:1})${KIND:1}"
Expand All @@ -277,7 +277,7 @@ jobs:
fi

echo "Running tests for Test${KIND_UPPER}Conformance/${KIND}/${NAME} ... "
echo "Source Pacakge: " ${{ matrix.source-pkg }}
echo "Source Package: " ${{ matrix.source-pkg }}

set +e
gotestsum --jsonfile ${{ env.TEST_OUTPUT_FILE_PREFIX }}_conformance.json \
Expand Down Expand Up @@ -335,13 +335,13 @@ jobs:
name: result_files
path: tmp/result_files
retention-days: 1

- name: Prepare coverage report file to upload
if: github.event_name == 'schedule'
run: |
mkdir -p tmp/conf_code_cov
cp cover.out tmp/conf_code_cov/${{ env.SOURCE_PATH_LINEAR }}.out

- name: Upload coverage report file
uses: actions/upload-artifact@v3
if: github.event_name == 'schedule'
Expand Down
Loading