fix: drop duplicate awsRegion/region field #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eileen-Yu
force-pushed
the
fix/duplicate-metadata
branch
from
7169ac8 to
d25a918
Compare
Signed-off-by: Eileen Yu <[email protected]>
Eileen-Yu
force-pushed
the
fix/duplicate-metadata
branch
from
d25a918 to
64d09bb
Compare
ItalyPaleAle
approved these changes
Jul 25, 2024
|
Thanks! |
Eileen-Yu
added a commit
to Eileen-Yu/components-contrib
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Eileen Yu <[email protected]>
yaron2
pushed a commit
that referenced
this pull request
Sep 9, 2024
#3490) (#3530) Signed-off-by: Eileen Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to cleanup the legacy of aws shared auth library, which cause the duplication of
components.authenticationProfiles.metadata.awsRegionandcomponents.metadata.region.By checking the
component-metadata-bundle.jsongenerated locally, I think this PR fixed those duplications.Issue reference
#3489
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: