mongodb: fix goroutine leak on failed server connections #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By not keeping the client when `Ping` fails we're later unable to properly invoke `Disconnect` which leads to leaked resources, most notably goroutines created on the mongo-go-driver. Signed-off-by: Luis Rascao <[email protected]>
lrascao
force-pushed
the
fix-mongodb-goroutine-leak-on-failed-connection
branch
from
4be7052 to
f99f664
Compare
JoshVanL
approved these changes
Sep 10, 2024
yaron2
approved these changes
Sep 10, 2024
|
@holopin-bot @lrascao Thank you for your contribution, Luis! |
|
Congratulations @lrascao, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm1ukyq5k82110cm8alj3rmep This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By not keeping the client when
Pingfails we're later unable to properly invokeDisconnectwhich leads to leaked resources, most notably goroutines created on the mongo-go-driver.Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: