Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bindings][BlobStorage] Update request.go - Log debug instead of warning #3577

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

ssi-spyro
Copy link
Contributor

@ssi-spyro ssi-spyro commented Oct 23, 2024

[Azure-BlobStorage] Log debug instead of warn when metadata has disallowed characters

Description

Log debug instead of warn when metadata has disallowed characters

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[4399]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests - not required for this case
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

[Azure-BlobStorage] Log debug instead of warn when metadata has disallowed characters

Signed-off-by: Seweryn Sirek <[email protected]>
@ssi-spyro ssi-spyro requested review from a team as code owners October 23, 2024 11:27
@ssi-spyro ssi-spyro changed the title Update request.go [Bindings][BlobStorage] Update request.go - Log debug instead of warning Oct 23, 2024
Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ssi-spyro

@berndverst berndverst merged commit 54d59d5 into dapr:main Oct 25, 2024
1 check passed
@marcduiker
Copy link
Contributor

@holopin-bot @ssi-spyro Thank you!

Copy link

holopin-bot bot commented Dec 3, 2024

Congratulations @ssi-spyro, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm487b4lq25460cjmrfj8swjg

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants