Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds conformance tests for AWS Secrets store component #3588

Merged
merged 11 commits into from
Nov 8, 2024
Merged

Adds conformance tests for AWS Secrets store component #3588

merged 11 commits into from
Nov 8, 2024

Conversation

elena-kolevska
Copy link
Contributor

Description

Adds conformance tests for the AWS Secrets manager component, so it can move to beta status

Issue reference

#3504

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@elena-kolevska
Adds conformance tests for AWS Secretes store component
559a60a 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
Adds cloud test
d64d8b7 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
Adds to test-info.mjs
0a78be2 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
Adds missing endpoint
94eacf4 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska changed the title Adds conformance tests for AWS Secretes store component Adds conformance tests for AWS Secrets store component Oct 31, 2024
@elena-kolevska elena-kolevska marked this pull request as ready for review October 31, 2024 19:26
@elena-kolevska elena-kolevska requested review from a team as code owners October 31, 2024 19:26
@elena-kolevska
Copy link
Contributor Author

The cloud test isn't running on the PR. Looks like it's dependent on an env variable. Maybe we have that set for runs on master only?

@elena-kolevska
Copy link
Contributor Author

The cloud test didn't run, looks like it needs the secrets.AZURE_KEYVAULT env variable set. Maybe it runs on master only?

@artursouza
Copy link
Member

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 1, 2024 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: 94eacf4

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • secretstores.aws.secretsmanager.terraform

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 1, 2024

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 94eacf4

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 1, 2024 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: 94eacf4

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • pubsub.gcp.pubsub
  • state.azure.cosmosdb
  • state.sqlserver

yaron2 and others added 2 commits November 4, 2024 09:46
@elena-kolevska
Copy link
Contributor Author

/ok-to-test

2 similar comments
@elena-kolevska
Copy link
Contributor Author

/ok-to-test

@yaron2
Copy link
Member

yaron2 commented Nov 4, 2024

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 4, 2024

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 5122595

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 4, 2024 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: 5122595

❌ Some certification tests failed

These tests failed:

  • bindings.azure.servicebusqueues
  • pubsub.gcp.pubsub
  • pubsub.mqtt3
  • state.azure.cosmosdb
  • state.cassandra
  • state.sqlserver

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 4, 2024 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: 5122595

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • secretstores.aws.secretsmanager.terraform
  • state.sqlserver

elena-kolevska and others added 3 commits November 6, 2024 00:10
@artursouza
Copy link
Member

/ok-to-test

2 similar comments
@artursouza
Copy link
Member

/ok-to-test

@artursouza
Copy link
Member

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 6deb586

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: 6deb586

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.azure.servicebusqueues
  • pubsub.gcp.pubsub
  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus.topics
  • state.azure.cosmosdb

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: 6deb586

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus.queues
  • secretstores.aws.secretsmanager.terraform
  • state.sqlserver

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: 6deb586

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • secretstores.aws.secretsmanager.terraform

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: 6deb586

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.azure.servicebusqueues
  • bindings.azure.storagequeues
  • pubsub.gcp.pubsub
  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus.topics
  • pubsub.mqtt3
  • state.azure.blobstorage
  • state.azure.cosmosdb
  • state.azure.tablestorage

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 6deb586

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: 6deb586

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus.queues
  • secretstores.aws.secretsmanager.terraform
  • state.azure.cosmosdb
  • state.sqlserver

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 6deb586

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: 6deb586

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.azure.servicebusqueues
  • bindings.azure.storagequeues
  • pubsub.gcp.pubsub
  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus.topics
  • state.azure.blobstorage
  • state.azure.cosmosdb
  • state.sqlserver

@elena-kolevska
fixes TF script
c9a1d5b 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
Copy link
Contributor Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: c9a1d5b

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • pubsub.kafka-confluent

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: c9a1d5b

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 6, 2024 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: c9a1d5b

❌ Some certification tests failed

These tests failed:

  • pubsub.aws.snssqs
  • pubsub.gcp.pubsub
  • state.azure.cosmosdb
  • state.sqlserver

@elena-kolevska
Copy link
Contributor Author

Passing on docker: https://github.com/dapr/components-contrib/actions/runs/11695560360/job/32572844939
Passing on cloud: https://github.com/dapr/components-contrib/actions/runs/11695560360/job/32572844760

@elena-kolevska
Copy link
Contributor Author

Draft PR here: dapr/docs#4421

@elena-kolevska elena-kolevska mentioned this pull request Nov 6, 2024
Merged
7 tasks
@yaron2 yaron2 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into dapr:main with commit b05e19a Nov 8, 2024
90 checks passed
@elena-kolevska elena-kolevska deleted the aws-sm branch November 8, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaron2 yaron2 yaron2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elena-kolevska @artursouza @dapr-bot @yaron2