Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for docker compose platform type #252

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

timcallaghan
Copy link
Contributor

Adding missing test coverage for previous PR - #217

@timcallaghan timcallaghan force-pushed the increase-test-coverage branch from 5331d9e to 6a4d79f Compare April 25, 2023 01:56
@timcallaghan
Copy link
Contributor Author

Hi @artursouza - here's a PR adding some test coverage for my previous PR

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #252 (a5d05d9) into master (4c87fc7) will increase coverage by 18.88%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master     #252       +/-   ##
===========================================
+ Coverage    8.67%   27.56%   +18.88%     
===========================================
  Files           7        7               
  Lines         795      798        +3     
===========================================
+ Hits           69      220      +151     
+ Misses        720      554      -166     
- Partials        6       24       +18     
Impacted Files Coverage Δ
pkg/components/components.go 35.00% <0.00%> (+35.00%) ⬆️
pkg/instances/instances.go 22.39% <100.00%> (+14.83%) ⬆️

... and 1 file with indirect coverage changes

@Mamotchenko
Copy link

Any news?

@oridotaoyebode
Copy link

  • 1 waiting patiently for this to be approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants