Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add dapr http client extensions #633

Closed

Conversation

karoldeland
Copy link

Description

Please explain the changes you've made

As mentioned in #632, basic implementation to see if it's a good idea or not.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #632

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@ghost
Copy link

ghost commented Mar 15, 2021

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #633 (0d05e81) into master (c401452) will increase coverage by 18.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #633       +/-   ##
===========================================
+ Coverage   47.77%   66.03%   +18.25%     
===========================================
  Files         125      125               
  Lines        4130     4139        +9     
  Branches      460      462        +2     
===========================================
+ Hits         1973     2733      +760     
+ Misses       2050     1282      -768     
- Partials      107      124       +17     
Flag Coverage Δ
net5 47.66% <0.00%> (-0.11%) ⬇️
netcoreapp3.1 66.03% <0.00%> (+18.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Dapr.AspNetCore/DaprServiceCollectionExtensions.cs 56.00% <0.00%> (-31.50%) ⬇️
src/Dapr.Actors/Builder/MethodDispatcherBuilder.cs 74.31% <0.00%> (+0.45%) ⬆️
src/Dapr.Actors/Runtime/ActorTypeInformation.cs 40.00% <0.00%> (+2.50%) ⬆️
src/Dapr.Actors/Runtime/ActorManager.cs 50.98% <0.00%> (+5.22%) ⬆️
src/Dapr.Actors/Description/MethodDescription.cs 69.04% <0.00%> (+9.52%) ⬆️
src/Dapr.Actors/Builder/InterfaceDetailsStore.cs 89.18% <0.00%> (+10.81%) ⬆️
src/Dapr.Actors/Client/ActorProxyOptions.cs 100.00% <0.00%> (+11.11%) ⬆️
...tors/Communication/ActorMessageHeaderSerializer.cs 54.71% <0.00%> (+11.32%) ⬆️
...Actors/Communication/ActorDataContractSurrogate.cs 12.50% <0.00%> (+12.50%) ⬆️
.../Dapr.Actors/Builder/MethodBodyTypesBuildResult.cs 100.00% <0.00%> (+13.33%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c401452...0d05e81. Read the comment docs.

@rynowak
Copy link
Contributor

rynowak commented Mar 19, 2021

Closing this as discussed in the issue - we decided not to proceed.

@rynowak rynowak closed this Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an extension method to add Dapr HTTP Client to service collection
2 participants