Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log options in HTTPServer to prevent circular reference #592

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

shubham1172
Copy link
Member

Description

Having a debug log with options was causing a circular reference while using HTTP Server (see attached issue). This PR simply removes the logs and fixes it.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #488

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172 shubham1172 requested review from a team as code owners April 23, 2024 17:00
@shubham1172 shubham1172 merged commit 7350742 into dapr:main Apr 24, 2024
7 of 8 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @shubham1172 :)

Copy link

holopin-bot bot commented May 7, 2024

Congratulations @shubham1172, you just earned a badge! Here it is: https://holopin.io/claim/clvwg8rgh02120fmem84boi2t

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypeError: Converting circular structure to JSON" while using custom winston logger service
3 participants