Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait longer for binding test to receive event to hopefully fix tests #616

Closed
wants to merge 1 commit into from

Conversation

greenie-msft
Copy link
Contributor

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@greenie-msft greenie-msft requested review from a team as code owners July 31, 2024 17:41
Copy link

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never hurts to try! :-)

@DeepanshuA
Copy link
Contributor

I agree, increasing time doesn't hurt. But, I don't think that is the issue here.
binding test is passing intermittently.
There are runs in existing PRs #616 and #615 which have un-successful runs as well.
I tried to reproduce on my local and it passed consistently, without any changes as well.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Sep 1, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Sep 1, 2024
@dapr-bot
Copy link
Collaborator

dapr-bot commented Sep 8, 2024

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants