Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sleep from integration test #102

Merged
merged 11 commits into from
Jul 17, 2021
Merged

Conversation

withinboredom
Copy link
Contributor

@withinboredom withinboredom commented Jul 17, 2021

Description

Add support for the metadata endpoint and shutdown.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.

Please reference the issue this PR: #36

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Tests pass
  • Created/updated tests
  • Extended the documentation

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #102 (44edb43) into main (5e2e0b4) will increase coverage by 9.48%.
The diff coverage is 46.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #102      +/-   ##
============================================
+ Coverage     68.71%   78.20%   +9.48%     
- Complexity      494      499       +5     
============================================
  Files            63       63              
  Lines          1819     1606     -213     
============================================
+ Hits           1250     1256       +6     
+ Misses          569      350     -219     
Impacted Files Coverage Δ
src/lib/Client/DaprClient.php 53.84% <ø> (ø)
src/lib/Client/DaprHttpClient.php 58.33% <33.33%> (-26.29%) ⬇️
src/lib/Client/MetadataResponse.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2e0b4...44edb43. Read the comment docs.

@withinboredom withinboredom merged commit 782eb94 into main Jul 17, 2021
@withinboredom withinboredom deleted the add/metadata-endpoint branch July 17, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants