Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor actors to use new client #104

Merged
merged 6 commits into from
Jul 24, 2021
Merged

Refactor actors to use new client #104

merged 6 commits into from
Jul 24, 2021

Conversation

withinboredom
Copy link
Contributor

@withinboredom withinboredom commented Jul 24, 2021

Description

Refactors actors to use the new dapr client

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to
implementation.

Please reference the issue this PR: #36

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Tests pass
  • Created/updated tests
  • Extended the documentation

@dapr dapr deleted a comment from codecov-commenter Jul 24, 2021
@dapr dapr deleted a comment from codecov-commenter Jul 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #104 (412c771) into main (e7968b9) will decrease coverage by 1.15%.
The diff coverage is 88.59%.

❗ Current head 412c771 differs from pull request most recent head 80744c5. Consider uploading reports for the commit 80744c5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #104      +/-   ##
============================================
- Coverage     78.20%   77.05%   -1.16%     
- Complexity      499      535      +36     
============================================
  Files            63       64       +1     
  Lines          1606     1739     +133     
============================================
+ Hits           1256     1340      +84     
- Misses          350      399      +49     
Impacted Files Coverage Δ
src/lib/Actors/Generators/GenerateProxy.php 100.00% <ø> (ø)
src/lib/Client/DaprClient.php 53.84% <ø> (ø)
src/lib/Client/DaprHttpClient.php 53.84% <0.00%> (-4.49%) ⬇️
src/lib/Client/HttpBindingTrait.php 0.00% <ø> (ø)
src/lib/Client/HttpInvokeTrait.php 0.00% <ø> (ø)
src/lib/Client/HttpPubSubTrait.php 100.00% <ø> (ø)
src/lib/Client/HttpSecretsTrait.php 100.00% <ø> (ø)
src/lib/Client/HttpStateTrait.php 81.03% <ø> (ø)
src/lib/Actors/ActorTrait.php 23.07% <60.00%> (-31.47%) ⬇️
src/lib/Deserialization/Deserializer.php 91.78% <60.00%> (-6.66%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7968b9...80744c5. Read the comment docs.

@withinboredom withinboredom merged commit 648006f into main Jul 24, 2021
@withinboredom withinboredom deleted the refactor/actors branch July 24, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants