Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: refactor for grpc client #37

Merged
merged 31 commits into from
Feb 4, 2021
Merged

Breaking change: refactor for grpc client #37

merged 31 commits into from
Feb 4, 2021

Conversation

withinboredom
Copy link
Contributor

@withinboredom withinboredom commented Feb 2, 2021

Description

This is basically a rewrite of the developer-facing API, inspired by slim/laravel/etc. It's much cleaner to work with and uses dependency injection instead of static methods. Almost none of the inner workings have changed.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR: #36

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@withinboredom withinboredom added the enhancement New feature or request label Feb 2, 2021
@withinboredom withinboredom self-assigned this Feb 2, 2021
@codecov-io
Copy link

codecov-io commented Feb 2, 2021

Codecov Report

Merging #37 (e1b080d) into main (29a5fdc) will decrease coverage by 5.85%.
The diff coverage is 55.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #37      +/-   ##
============================================
- Coverage     67.52%   61.67%   -5.86%     
- Complexity      413      416       +3     
============================================
  Files            51       55       +4     
  Lines          1469     1469              
============================================
- Hits            992      906      -86     
- Misses          477      563      +86     
Impacted Files Coverage Δ Complexity Δ
src/index.php 0.00% <0.00%> (ø) 2.00 <1.00> (-10.00)
src/lib/Actors/.phpstorm.meta.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/lib/Actors/ActorProxy.php 0.00% <0.00%> (-100.00%) 2.00 <2.00> (ø)
src/lib/Actors/HealthCheck.php 0.00% <0.00%> (ø) 1.00 <1.00> (?)
src/lib/App.php 0.00% <0.00%> (ø) 35.00 <35.00> (?)
src/lib/DaprClient.php 0.00% <0.00%> (ø) 24.00 <24.00> (+2.00)
src/lib/Deserialization/.phpstorm.meta.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/lib/Deserialization/Attributes/ArrayOf.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/lib/Deserialization/Attributes/Union.php 0.00% <0.00%> (ø) 1.00 <1.00> (ø)
...c/lib/Deserialization/InvokerParameterResolver.php 0.00% <0.00%> (ø) 4.00 <4.00> (?)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a5fdc...e1b080d. Read the comment docs.

@withinboredom withinboredom changed the title Breaking change: refactor for gprc client Breaking change: refactor for grpc client Feb 4, 2021
@withinboredom withinboredom merged commit ffe7fd2 into main Feb 4, 2021
@withinboredom withinboredom deleted the add/gprc branch February 4, 2021 21:11
@withinboredom withinboredom added this to the 1.0.0-rc.4 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants