Fix return type of resource enter protocol in DaprGrpcClient. Fixes #520 #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dag Brattli <[email protected]>
berndverst
approved these changes
Jan 11, 2023
berndverst
approved these changes
Jan 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 57 57
Lines 2613 2614 +1
=======================================
+ Hits 2347 2348 +1
Misses 266 266
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tmacam
added a commit
to tmacam/dapr-python-sdk
that referenced
this pull request
Mar 20, 2023
PR dapr#521 added an implicit dependency on `typing-extensions`. During development this dependency is satisfied as it is mentioned on `dev-requirements.txt`. However, new instalations of the Python SDK will not bring this pendency and applications depending on `dapr.client.DaprClient` will fail to load with an import exception. This PR addresses this by adding `typing-extensions` to the dependency list of the generated python sdk package. Closes dapr#544
3 tasks
tmacam
added a commit
to tmacam/dapr-python-sdk
that referenced
this pull request
Mar 20, 2023
PR dapr#521 added an implicit dependency on `typing-extensions`. During development this dependency is satisfied as it is mentioned on `dev-requirements.txt`. However, new instalations of the Python SDK will not bring this pendency and applications depending on `dapr.client.DaprClient` will fail to load with an import exception. This PR addresses this by adding `typing-extensions` to the dependency list of the generated python sdk package. Closes dapr#544 Signed-off-by: Tiago Alves Macambira <[email protected]>
berndverst
pushed a commit
that referenced
this pull request
Mar 21, 2023
PR #521 added an implicit dependency on `typing-extensions`. During development this dependency is satisfied as it is mentioned on `dev-requirements.txt`. However, new instalations of the Python SDK will not bring this pendency and applications depending on `dapr.client.DaprClient` will fail to load with an import exception. This PR addresses this by adding `typing-extensions` to the dependency list of the generated python sdk package. Closes #544 Signed-off-by: Tiago Alves Macambira <[email protected]>
berndverst
pushed a commit
to berndverst/python-sdk
that referenced
this pull request
Mar 21, 2023
PR dapr#521 added an implicit dependency on `typing-extensions`. During development this dependency is satisfied as it is mentioned on `dev-requirements.txt`. However, new instalations of the Python SDK will not bring this pendency and applications depending on `dapr.client.DaprClient` will fail to load with an import exception. This PR addresses this by adding `typing-extensions` to the dependency list of the generated python sdk package. Closes dapr#544 Signed-off-by: Tiago Alves Macambira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes return type of
DaprGrpcClientso that sub-classes i.eDaprClientgets the right type back when doingwith DaprClient as d.Note that mypy does not currently handle the
Selftype python/mypy#14089 so we need a new version of mypy for this to work. Current version of mypy gives:Variable "typing_extensions.Self" is not valid as a type [valid-type]. To make it work I've added# type: ignoreon the line which seems to work with both current version of mypy and sub-classes gets the right type with type checkers such as pyright.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #520
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: