Make sure that all operants are of same type when handling PCG64 stream

daqana · May 16, 2024 · fd688fb · fd688fb
1 parent 4287aca
commit fd688fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/inst/include/dqrng_generator.h b/inst/include/dqrng_generator.h
@@ -112,7 +112,7 @@ inline void random_64bit_wrapper<pcg64>::set_stream(result_type stream) {
     state.push_back(number);
   // state[1] is the current stream
   // PCG will do 2*stream + 1 to make sure stream is odd; need to revert that here
-  gen.set_stream(state[1]/2 + stream);
+  gen.set_stream(state[1]/pcg_extras::pcg128_t(2) + pcg_extras::pcg128_t(stream));
 }
 
 // keep using the two argument ctor for PCG for backwards compatibility

diff --git a/inst/include/pcg_random.hpp b/inst/include/pcg_random.hpp
@@ -319,7 +319,7 @@ class specific_stream {
 
     void set_stream(itype specific_seq)
     {
-         inc_ = (specific_seq << 1) | 1;
+         inc_ = (specific_seq << 1) | itype(1U);
     }
 
     static constexpr bool can_specify_stream = true;