Add missing inline attributes to avoid linker issues. #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xoshiro<2>::do_jump
specializations need someinline
attribute, otherwise including dqrng from multiple compilation units causes linker errors due to symbols being defined multiple times.While compiling against the latest pre-release, I hit some build errors which this should fix.Firstly, thedqrng_types.h
file was includingRcpp/Lightest
, which should provide a slimmer interface to Rcpp. Unfortunately, the decision to include that file is "infectious" and impacts any compilation unit which includes dqrng. This is because includingRcpp/Lightest
ends up definingRcpp_hpp
, and subsequent includes ofRcpp.h
do nothing. My end applipcation was unable to use Rcpp's extended API because of this.