allow variables from environment in queries in ppx #119
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismamo1
reviewed
Jun 5, 2022
| match Sys.getenv_opt v with | ||
| | None -> q | ||
| | Some nv -> | ||
| Re.Str.global_replace (Re.Str.regexp ("\\$" ^ v)) nv q) query vars in |
There was a problem hiding this comment.
Minor stylistic gripe here. It's a bit hard to read this with query vars tucked in on the last line like that. I would spread it out a bit more so it's clear this isn't a partial application of fold_left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set for example table names depending on the environment:
[%pgsql dbh "var=FOO" "select * from table_$FOO"]compiled with
FOO=42 dune buildwill select rows fromtable_42