Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make folder select UI as separate component #115

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Make folder select UI as separate component #115

merged 2 commits into from
Dec 13, 2024

Conversation

dark-person
Copy link
Owner

@dark-person dark-person commented Dec 8, 2024 •
edited
Loading

Changes Made

  • Add UI component folder selector (from original folder select input group)
  • Change export panel & folder select panel to use new component

Reason of Changes

Provide UI component for future custom wrap folder development.

Checklist:

  • I have run the new code and ensure the change is work expected
  • I have write/modify comments to important function & hard-to-understand code
  • I have create/modify corresponding test for new changes
  • I have made corresponding changes to the documentation
  • I have run all new & existing test and pass locally with my changes
  • I have checked my code has no misspellings & no warnings
  • I have checked that only essential code remains in this pull request

@dark-person dark-person added the enhancement[unused] Improvement of Existing Feature label Dec 8, 2024
@dark-person dark-person added this to the v0.8.0 milestone Dec 8, 2024
@dark-person dark-person marked this pull request as ready for review December 13, 2024 13:06
@dark-person dark-person merged commit 4812eb2 into master Dec 13, 2024
3 checks passed
@dark-person dark-person deleted the ui/folder-selector branch December 13, 2024 13:06
@dark-person dark-person added codes/quality Improvement to code quality and removed enhancement[unused] Improvement of Existing Feature labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codes/quality Improvement to code quality
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@dark-person