Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite wails directory dialog & folder selector #125

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Rewrite wails directory dialog & folder selector #125

merged 3 commits into from
Jan 19, 2025

Conversation

dark-person
Copy link
Owner

@dark-person dark-person commented Jan 19, 2025 •
edited
Loading

Changes Made

Rewrite wails directory dialog API to simpler implementation.

Reason of Changes

  1. The original API may be complex and not flexible
  2. Default directory behaviour confused due to it open parent folder instead of given directory.

Checklist:

  • I have run the new code and ensure the change is work expected
  • I have write/modify comments to important function & hard-to-understand code
  • I have create/modify corresponding test for new changes
  • I have made corresponding changes to the documentation
  • I have run all new & existing test and pass locally with my changes
  • I have checked my code has no misspellings & no warnings
  • I have checked that only essential code remains in this pull request

@dark-person dark-person added codes/quality Improvement to code quality ui/user-experience Improvement on UX for UI labels Jan 19, 2025
@dark-person dark-person added this to the v0.8.0 milestone Jan 19, 2025
@dark-person dark-person marked this pull request as ready for review January 19, 2025 15:00
@dark-person dark-person merged commit fe4c5fb into master Jan 19, 2025
3 checks passed
@dark-person dark-person deleted the rewrite/directory-api branch January 19, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codes/quality Improvement to code quality ui/user-experience Improvement on UX for UI
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@dark-person