PEP8: Never use equality operators to compare to singletons #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://peps.python.org/pep-0008/#programming-recommendations
%
ruff rule E712
true-false-comparison (E712)
Derived from the pycodestyle linter.
Fix is always available.
What it does
Checks for equality comparisons to boolean literals.
Why is this bad?
PEP 8 recommends against using the equality operators
==
and!=
tocompare values to
True
orFalse
.Instead, use
if cond:
orif not cond:
to check for truth values.If you intend to check if a value is the boolean literal
True
orFalse
,consider using
is
oris not
to check for identity instead.Example
Use instead:
Fix safety
This rule's fix is marked as unsafe, as it may alter runtime behavior when
used with libraries that override the
==
/__eq__
or!=
/__ne__
operators.In these cases,
is
/is not
may not be equivalent to==
/!=
. For moreinformation, see this issue.