Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cart.php #13

Closed
wants to merge 1 commit into from
Closed

Update Cart.php #13

wants to merge 1 commit into from

Conversation

onyanov
Copy link

@onyanov onyanov commented May 1, 2015

No description provided.

@darryldecode
Copy link
Owner

Hi @onyanov, thank you for your time. I guess you miss this in docs:

$cartCollection = Cart::getContent();
$cartCollection->count();

I am also not sure why we need to count it base on all item's quantity at once? since each item is unique.

@onyanov
Copy link
Author

onyanov commented May 1, 2015

Hi @darryldecode. This way doesn't consider on quantity of each product.

@darryldecode
Copy link
Owner

@onyanov, yes you're right. But it might be confusing with getting total items in the cart vs getting total items(with respect to their quantity) in the cart? Or perhaps maybe there's a better method name for that?

@darryldecode
Copy link
Owner

Hi @onyanov, can you do a rebase on this PR before I can do a merge on this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants