Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Commit

Permalink
Support latest package:vm_service (#328)
Browse files Browse the repository at this point in the history
  • Loading branch information
grouma authored Jan 20, 2021
1 parent 53a5748 commit 4840222
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.15.1 - 2021-01-14

* Updated dependency on `vm_service` package from `>=1.0.0 < 5.0.0` to `>=1.0.0 <7.0.0`.

## 0.15.0 - 2021-01-13

* BREAKING CHANGE: Eliminate the `--package-root` option from
Expand Down
8 changes: 6 additions & 2 deletions lib/src/collect.dart
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ Future<Map<String, dynamic>> collect(Uri serviceUri, bool resume,
log: StdoutLog(), disposeHandler: () => socket.close());
await service.getVM().timeout(_retryInterval);
} on TimeoutException {
service.dispose();
// The signature changed in vm_service version 6.0.0.
// ignore: await_only_futures
await service.dispose();
rethrow;
}
}, _retryInterval, timeout: timeout);
Expand All @@ -75,7 +77,9 @@ Future<Map<String, dynamic>> collect(Uri serviceUri, bool resume,
if (resume) {
await _resumeIsolates(service);
}
service.dispose();
// The signature changed in vm_service version 6.0.0.
// ignore: await_only_futures
await service.dispose();
}
}

Expand Down
10 changes: 2 additions & 8 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: coverage
version: 0.15.0
version: 0.15.1
description: Coverage data manipulation and formatting
homepage: https://github.com/dart-lang/coverage

Expand All @@ -13,19 +13,13 @@ dependencies:
path: '>=0.9.0 <2.0.0'
source_maps: ^0.10.8
stack_trace: ^1.3.0
vm_service: '>=1.0.0 <6.0.0'
vm_service: '>=1.0.0 <7.0.0'

dev_dependencies:
pedantic: ^1.0.0
test: ^1.16.0-nullsafety.4
test_descriptor: ^1.2.0

dependency_overrides:
test: 1.16.0-nullsafety.13
test_core: 0.3.12-nullsafety.12
test_api: 0.2.19-nullsafety.6

executables:
collect_coverage:
format_coverage:

0 comments on commit 4840222

Please sign in to comment.