Add Wasm support

[h1376h]

Since dart:html is not supported when compiling to Wasm, the correct alternative now is to use dart.library.js_interop to differentiate between native and web

Source:
https://dart.dev/interop/js-interop/package-web

• Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[kevmoo]

Actually, this is by design!

We can use the fast sinks in wasm because it has full 64bit numbers, unlike JS.

[kevmoo]

We should probably add a comment here to clarify!

[kevmoo]

Right @lrhn ?

[h1376h]

Actually, this is by design!

We can use the fast sinks in wasm because it has full 64bit numbers, unlike JS.

The latest version of this package in pub.dev has wrong conditional imports, you fixed it 5 months ago with a PR #165 (by checking dart.library.html instead of dart.library.js so Wasm builds could use fast sinks).

import 'library_html_false.dart'
    if (dart.library.html) 'library_html_true.dart';
import 'library_js_false.dart' if (dart.library.js) 'library_js_true.dart';
import 'library_js_interop_false.dart'
    if (dart.library.js_interop) 'library_js_interop_true.dart';

In Wasm builds, library_html_false, library_js_interop_true and library_js_true would be chosed, so the current latest version on pub.dev is using the 32Bit implementation (slow sinks) on Wasm.

TLDR;
The package needs to be updated so it could have your fix from 5 months ago!

[kevmoo]

@h1376h – meaning you'd like me to publish?

[h1376h]

@h1376h – meaning you'd like me to publish?

If fast sinks are faster than slow sinks, yeah! It would be great if that change could be published. Am currently testing both on Wasm to check the benchmarks.

[h1376h]

dart-lang/core#250 Found some issues when testing fast sinks on Wasm