Skip to content
This repository has been archived by the owner on Jan 28, 2024. It is now read-only.

Prevent warnings in FfiNative example #479

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Prevent warnings in FfiNative example #479

merged 2 commits into from
Oct 25, 2022

Conversation

dcharkes
Copy link
Contributor

FfiNative will be deprecated and we will introduce Native (with slightly different syntax).

See discussion

And CL: https://dart-review.googlesource.com/c/sdk/+/265084

Adding a lint ignore here to prevent this example from starting to throw warnings when this lands.

mannprerak2
mannprerak2 approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@mannprerak2 mannprerak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you'd need to add the preamble here as well for the example tests to pass - test/example_tests/ffinative_example_test.dart

@dcharkes dcharkes requested a review from liamappelbe October 24, 2022 11:12
@dcharkes dcharkes merged commit 411fc21 into master Oct 25, 2022
@dcharkes dcharkes deleted the ffi-native-deprecated branch October 25, 2022 06:31
@dcharkes
Copy link
Contributor Author

Thanks @liamappelbe and @mannprerak2 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamappelbe liamappelbe liamappelbe approved these changes

@mannprerak2 mannprerak2 mannprerak2 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcharkes @liamappelbe @mannprerak2