Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Buffer concurrent requests #51

Merged
merged 2 commits into from
Jun 5, 2021
Merged

Buffer concurrent requests #51

merged 2 commits into from
Jun 5, 2021

Conversation

grouma
Copy link
Contributor

@grouma grouma commented Jun 4, 2021

@grouma grouma requested a review from jacob314 June 4, 2021 23:22
///
/// Chrome drops outgoing requests on the floor after some threshold. To prevent
/// these errors we buffer outgoing requests with a pool.
final _requestPool = Pool(1000);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it is probably all browsers not chrome. Comment on why 1000 is chosen for the pool size.

@jacob314
Copy link

jacob314 commented Jun 4, 2021

lgtm

@grouma grouma merged commit d505b38 into master Jun 5, 2021
@grouma grouma deleted the pool branch June 5, 2021 00:02
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
* Buffer concurrent requests

* comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants