This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Move from travis to github actions #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #54
grouma
approved these changes
Aug 30, 2021
|
Grr...one failing test! |
…same connection is sufficient for the intent of the test
kevmoo
approved these changes
Aug 31, 2021
natebosch
commented
Aug 31, 2021
|
|
||
| // Ensure there's still a connection and it's marked as in the keep-alive | ||
| // state. | ||
| expect(connection.isInKeepAlivePeriod, isTrue); |
There was a problem hiding this comment.
@grouma - Do you think that the round tripping of the value 'bar' through the same connection object as was used before and already closed should be sufficient for this test?
I could add a stream of reconnect events, but I don't think it's necessary to demonstrate correctness here.
WDYT?
There was a problem hiding this comment.
That's probably fine since closeSink is synchronous and should guarantee that the connection is severed before we send bar.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
Closes dart-lang/sse#54 Fix formatting in one file. Remove test expectations around keep alive periods. Testing communication through the same connection that had been closed is sufficient for the intent of the test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/tools#1648