Fix order-dependent test: test the correct instance(s).

[davidmorgan]

No description provided.

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:build	2.4.2	already published at pub.dev
package:build_config	1.1.2	already published at pub.dev
package:build_daemon	4.0.4	ready to publish	build_daemon-v4.0.4
package:build_modules	5.0.11	already published at pub.dev
package:build_resolvers	2.4.4-wip	WIP (no publish necessary)
package:build_runner	2.4.15-wip	WIP (no publish necessary)
package:build_runner_core	8.0.1-dev	ready to publish	build_runner_core-v8.0.1-dev
package:build_test	2.2.4-wip	WIP (no publish necessary)
package:build_web_compilers	4.1.1	already published at pub.dev
package:scratch_space	1.0.3-wip	WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[github-actions]

PR Health

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

[jensjoha]

Does this still have to be async? Or should the calls actually be await resolver.libraryFor as below?

[davidmorgan]

Actually, reverted that attempt at a fix.

I realized both these tests were missing resolvers: createResolvers(), which means all four test variants were testing the same shared instance. So, that's the correct fix--done. Thanks!

[jensjoha]

I can seemingly not put comments on lines further down --- but why does these in particular have to change when stuff further down looks to be done the same way as these were before?

[davidmorgan]

Yeah, GitHub doesn't let you comment on unchanged lines--an annoying limitation.

The tests were actually correct, reverted, added resolvers: createResolvers() so we test the right instance, which is now I hope the correct fix :) thanks!