Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1837. Add additional unnecessary null-ckeck warnings #1842

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Feb 8, 2023

No description provided.

@sgrekhov
Copy link
Contributor Author

@eernstg @chloestefantsova friendly ping :)

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit ae74b46 into dart-lang:master Feb 15, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 21, 2023
2023-02-17 [email protected] dart-lang/co19#1399. [Records] Allow legacy libraries that don't support records to still be able to see the Record class in "dart:core" (dart-lang/co19#1571)
2023-02-17 [email protected] dart-lang/co19#1860. Fix type_inference_A12_t01.dart. Don't expect warning (dart-lang/co19#1862)
2023-02-17 [email protected] Fixes dart-lang/co19#1860. Fix roll failures (dart-lang/co19#1861)
2023-02-16 [email protected] dart-lang/co19#1401. Calculating the static type of the pattern tests added (dart-lang/co19#1847)
2023-02-16 [email protected] dart-lang/co19#1401. Shared case scope test with labels and default case added (dart-lang/co19#1858)
2023-02-15 [email protected] Fixes dart-lang/co19#1837. Add additional unnecessary null-ckeck warnings (dart-lang/co19#1842)

Change-Id: I3a1f5deafd4f2868574f085495417ed37fe845b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284080
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1837 branch March 22, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants