Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use values iterator and update in map equality/hash (#718)" #858

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

jakemac53
Copy link
Contributor

This reverts commit 1156cfe.

This broke some internal tests which have non conforming map implementations.

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

github-actions bot commented Feb 11, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage
pkgs/collection/lib/src/equality.dart 💚 89 % ⬆️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@jakemac53
Copy link
Contributor Author

jakemac53 commented Feb 11, 2025

Not sure why it thinks this is breaking 🤔 , I just updated it to ignore the check

@jakemac53 jakemac53 merged commit 0b2bd3f into main Feb 11, 2025
21 checks passed
@jakemac53 jakemac53 deleted the revert-use-values-iterator branch February 11, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants