Bump to analyzer 5.1.0 and handle deprecations #1140
Conversation
|
I think test and analyzer 5.0.0 have some pub version solve issue, so that effectively, analyzer 5.0.0 paired with package:test are only supported on Dart 2.18.0. Should I change the GitHub actions to handle this? (As it is, I guess we're now testing 2.17.0 and 2.19.0-dev.) |
|
I've merged in a bump to the GitHub actions, combining #1142 with this. Good talk. |
|
This is a preliminary step to #1141 PTAL @munificent @natebosch |
| @@ -2022,7 +2022,7 @@ class SourceVisitor extends ThrowingAstVisitor { | |||
| _simpleStatement(node, () { | |||
| token(node.libraryKeyword); | |||
| space(); | |||
| visit(node.name); | |||
| visit(node.name2); | |||
There was a problem hiding this comment.
what's happening with this one?
There was a problem hiding this comment.
In analyzer 5.1.0, .name is deprecated in favor of .name2.
There was a problem hiding this comment.
Is this on a different type than the rest of the invocations?
There was a problem hiding this comment.
Oops, my bad. In all of the other changes, .name2 is deprecated in favor of .name.
For this change, LibraryDirective.name, a non-nullable String is being replaced with LibraryDirective.name2, a nullable String (for the case of an omitted named).
| @@ -9,7 +9,7 @@ environment: | |||
| sdk: ">=2.17.0 <3.0.0" | |||
|
|
|||
| dependencies: | |||
| analyzer: '>=4.4.0 <6.0.0' | |||
There was a problem hiding this comment.
I can't leave a comment on the right line - but we need to bump the version of dart_style
|
Yeah that is definitely a weird situation in this release. Accidental on my and Konstantin's part. |
Since one of the deprecations is moving
.name2back to.name, I think it's necessary to bump the lower bound. In analyzer 4.4.0,.namemay have meant a different thing...In any case, analyzer 5.1.0 is the first release to allow unnamed libraries, so I think it is necessary for the follow up PR which adds such support in dart_style.