Format extension types. #1387
Merged
Format extension types. #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles metadata everywhere except on for loop variables. I'll do that later after patterns in for loops are supported. Since there were some metadata tests on pattern variable declarations, this also includes a trivial implementation of that. There's a TODO to revisit it and add real tests, but it's enough for the metadata tests. Figuring out where to put the metadata-handling code was a little tricky since so many places in the language can have metadata. I ultimately decided to put it into AdjacentBuilder. Every place that was working with metadata also had one of those builders in play, so that made it easy to add a simple call to `b.metadata()` and get the metadata working. It does mean that AdjacentBuilder isn't strictly about adjacent pieces anymore, but I think that's OK. In practice, it's used mostly as a general "build pieces out of smaller things" builder.
Nothing particularly interesting here, but it did flush out a little bug in PieceFactory.createParameter() where a comment before the metadata annotation would get moved to after the parameter.
natebosch
approved these changes
Feb 15, 2024
# Conflicts: # lib/src/front_end/piece_factory.dart # test/declaration/metadata.unit
kallentu
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing particularly interesting here, but it did flush out a little bug in
PieceFactory.createParameter()where a comment before the metadata annotation would get moved to after the parameter.