Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print detailed info about the leaked APIs to stdout in the workflow #339

Merged
merged 3 commits into from
Jan 23, 2025
Merged

print detailed info about the leaked APIs to stdout in the workflow #339

merged 3 commits into from
Jan 23, 2025

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Jan 23, 2025 •
edited
Loading

  • print detailed info about the leaked APIs to stdout in the workflow
  • remove some (non-lexical) sorting from our publishing status makrdown table; with larger mono-repos, having the packages not be lexically ordered can be confusing
  • rev the firehose package version and prep for publishing
  • fix Health workflow: Show leakage origins #333
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested a review from mosuem as a code owner January 23, 2025 04:08
@github-actions GitHub Actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:dart_flutter_team_lints 3.3.0 already published at pub.dev
package:firehose 0.10.2 ready to publish firehose-v0.10.2

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions GitHub Actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose None 0.10.1 0.10.2 0.10.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/firehose/lib/firehose.dart 💔 0 % ⬇️ NaN %
pkgs/firehose/lib/src/health/health.dart 💔 94 % ⬇️ 0 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem
Copy link
Member

mosuem commented Jan 23, 2025

We could also show the origins as <details> in the comment?

@devoncarew
Copy link
Member Author

We could also show the origins as <details> in the comment?

I think this makes sense. I'd like to see what info is in the json currently, so would want to land this PR as an incremental step there.

@devoncarew devoncarew merged commit c4a163a into main Jan 23, 2025
14 checks passed
@devoncarew devoncarew deleted the print_leaked_api branch January 23, 2025 22:15
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 27, 2025
@devoncarew
[deps] rev core, ecosystem, test, webdev
732fa5e 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/72a2060..3b35aca):
  3b35aca9  2025-01-24  Devon Carew  update the topics section of several pubspecs (dart-lang/core#854)

ecosystem (https://github.com/dart-lang/ecosystem/compare/682c8ef..c4a163a):
  c4a163a  2025-01-23  Devon Carew  print detailed info about the leaked APIs to stdout in the workflow (dart-lang/ecosystem#339)

test (https://github.com/dart-lang/test/compare/7fc9521..92eed6c):
  92eed6c4  2025-01-27  Lasse R.H. Nielsen  Make zone handlers call zone.run to run callbacks. (dart-lang/test#2451)
  ad04f172  2025-01-24  Devon Carew  add a pull request labeler; add issue tracker links; update codeowners file (dart-lang/test#2452)
  1f292db8  2025-01-24  Lasse R.H. Nielsen  Don't require Dart 3.5.
  a56fa947  2025-01-24  Lasse R.H. Nielsen  Accept extra `run`s in test. Move to Dart 3.5.
  4bd54972  2025-01-24  Lasse R.H. Nielsen  Clean-up. Accidentally merged a removed lint back in.
  9fa57d16  2025-01-24  Lasse R.H. Nielsen  Make zone handlers call zone.run to run callbacks.

webdev (https://github.com/dart-lang/webdev/compare/9430dd7..5dc7950):
  5dc79508  2025-01-24  Jessy Yameogo  Added support for callLibraryMethod with the DDC library bundle format.  (dart-lang/webdev#2577)
  1d0b32c2  2025-01-24  Srujan Gaddam  Reset DWDS to 24.3.4-wip (dart-lang/webdev#2580)
  1990d29a  2025-01-23  Srujan Gaddam  Implement hot restart for DDC library bundle format and publish 24.3.3 (dart-lang/webdev#2576)

Change-Id: Ifa23e74a1399ac7ec70a99750419b915a2efbb19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406120
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosuem mosuem mosuem approved these changes

Assignees
No one assigned
Labels
package:firehose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Health workflow: Show leakage origins
2 participants
@devoncarew @mosuem