Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

add combinators_ordering #3468

Merged
merged 2 commits into from
Jul 11, 2022
Merged

add combinators_ordering #3468

merged 2 commits into from
Jul 11, 2022

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Jun 23, 2022

Description

DO sort combinator names alphabetically.

BAD:

import 'a.dart' show B, A hide D, C;
export 'a.dart' show B, A hide D, C;

GOOD:

import 'a.dart' show A, B hide C, D;
export 'a.dart' show A, B hide C, D;

Fixes dart-lang/sdk#58400

@coveralls
Copy link

coveralls commented Jun 23, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 95.706% when pulling bf13475 on a14n:combinators_ordering into 31185f0 on dart-lang:master.

bwilkerson
bwilkerson reviewed Jun 23, 2022
View reviewed changes
Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also have tests for hide combinators. Other than that, the code looks fine.

@a14n
Copy link
Contributor Author

a14n commented Jul 11, 2022

PTAL

bwilkerson
bwilkerson approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

pq
pq approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@pq pq merged commit 8053b74 into dart-lang:master Jul 11, 2022
@a14n a14n deleted the combinators_ordering branch July 11, 2022 15:45
mockturtl added a commit to mockturtl/tidy that referenced this pull request Jul 19, 2022
@mockturtl
feat: combinators_ordering
930fba9 
dart-lang/linter#3468
@blendthink blendthink mentioned this pull request Sep 6, 2022
Open
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@a14n
add combinators_ordering (dart-lang/linter#3468)
8df9204 
* add combinators_ordering

* address review comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pq pq pq approved these changes

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

directives_ordering rule should order also show/hide list
4 participants
@a14n @coveralls @pq @bwilkerson