This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
add library_annotations; remove package_prefixed_library_names #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
approved these changes
Feb 8, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Feb 13, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. crypto (https://github.com/dart-lang/crypto/compare/c954015..f059196): f059196 2024-02-08 Kevin Moore Test dart2wasm (dart-archive/crypto#162) dartdoc (https://github.com/dart-lang/dartdoc/compare/457c34e..f152c01): f152c013 2024-02-08 Sam Rawlins Tidy spacing in templates (dart-lang/dartdoc#3652) d0c53b9f 2024-02-07 Sam Rawlins Change all late final Iterable fields to Lists (dart-lang/dartdoc#3649) 8c9c7790 2024-02-06 Sam Rawlins Remove unnecessary ExtensionTarget mixin (dart-lang/dartdoc#3648) d2f90c5a 2024-02-06 Sam Rawlins Fix the 'serve testing-package' task to generate docs (dart-lang/dartdoc#3647) ecosystem (https://github.com/dart-lang/ecosystem/compare/7d8ec47..3e4f286): 3e4f286 2024-02-08 Moritz Add ignore flag for `publish.yaml` (dart-lang/ecosystem#237) lints (https://github.com/dart-lang/lints/compare/90a61e4..ead7708): ead7708 2024-02-08 Devon Carew add library_annotations; remove package_prefixed_library_names (dart-lang/lints#179) native (https://github.com/dart-lang/native/compare/876f9a1..cb9bd7e): cb9bd7ef 2024-02-09 Daco Harkes Build hook spec (dart-lang/native#955) sse (https://github.com/dart-lang/sse/compare/e483b14..af7d8d0): af7d8d0 2024-02-09 Ilya Yanok Make `SseConnection` extend `StreamChannelMixin<String>` (dart-archive/sse#102) Change-Id: I2e85dbfae00eea8de7b6f7efce1993bf00e243f0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352046 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]> Auto-Submit: Devon Carew <[email protected]>
lrhn
reviewed
Feb 14, 2024
| @@ -5,7 +5,7 @@ | |||
| <!-- core --> | |||
| | Lint Rules | Description | [Fix][] | | |||
| | :--------- | :---------- | ------- | | |||
| | [`avoid_empty_else`](https://dart.dev/lints/avoid_empty_else) | Avoid empty else statements. | ✅ | | |||
| | [`avoid_empty_else`](https://dart.dev/lints/avoid_empty_else) | Avoid empty statements in else clauses. | ✅ | | |||
There was a problem hiding this comment.
in -> as
The "in" sounds like it includes {print();;}. Not that you shouldn't avoid that anyway, but this is not the lint for it.
(Does the lint only target ;, or also {}?)
There was a problem hiding this comment.
I believe the ultimate system-of-record for this info are the lint descriptions at https://github.com/dart-lang/sdk/tree/main/pkg/linter/lib/src/rules. Any changes there will flow here (in a few steps).
lrhn
reviewed
Feb 14, 2024
| @@ -11,7 +11,7 @@ | |||
| }, | |||
| { | |||
| "name": "avoid_empty_else", | |||
| "description": "Avoid empty else statements.", | |||
| "description": "Avoid empty statements in else clauses.", | |||
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library_annotations(closes Addlibrary_annotationscore#820)package_prefixed_library_names(closes Removepackage_prefixed_library_namesfrom core set (and deprecate) core#818)Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.