Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffigen] Disable health check for ffigen #1858

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[ffigen] Disable health check for ffigen #1858

merged 2 commits into from
Jan 6, 2025

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe requested a review from mosuem January 3, 2025 02:12
@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:ffigen labels Jan 3, 2025
@liamappelbe liamappelbe changed the title Disable health check for ffigen [ffigen] Disable health check for ffigen Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
ffi None 2.1.3 2.1.3 2.1.3 ✔️
jni None 0.13.0 0.13.0 0.13.0 ✔️
native_assets_builder None 0.10.2 0.10.2 0.10.2 ✔️
native_assets_cli None 0.10.0 0.10.0 0.10.0 ✔️
native_toolchain_c None 0.7.0 0.7.0 0.7.0 ✔️
objective_c Non-Breaking 4.0.0 4.1.0-wip 4.1.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
ffi MallocAllocator
CallocAllocator
jni _opaque_pthread_mutex_t
_opaque_pthread_cond_t
_Dart_FinalizableHandle
_ReferenceType
objective_c ObjCBlockBase
c._ObjCBlockImpl
_ObjCBlockDesc
_ObjCBlockRef
_ObjCObject
_Dart_FinalizableHandle
_ObjCProtocol
_ObjCSelector
_ObjCMethodDesc
_ObjCObjectRef
_NSZone

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ⚠️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_assets_builder/test_data/native_dynamic_linking/bin/native_dynamic_linking.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

@liamappelbe liamappelbe merged commit 1deeac7 into main Jan 6, 2025
22 checks passed
@liamappelbe liamappelbe deleted the health branch January 6, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ffigen type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants