Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_cli] Add HookInput.outputFile #1882

Merged
merged 3 commits into from
Jan 13, 2025
Merged

[native_assets_cli] Add HookInput.outputFile #1882

merged 3 commits into from
Jan 13, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jan 10, 2025

Pass in a path to where the output.json should be written.

This enables the output file to not be written into the output directory but next to it. This is cleaner.

I don't remember where we discussed this, but some references to adding the output json can be found in the discussions here:

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Jan 10, 2025

Coverage Status

coverage: 87.738% (+0.01%) from 87.728%
when pulling dd2dc72 on output-file
into a7fb6ee on main.

@dcharkes dcharkes requested a review from mosuem January 10, 2025 17:15
@@ -16,5 +16,5 @@ enum Hook {

String get scriptName => '$_scriptName.dart';

String get outputName => '${_scriptName}_output.json';
String get outputNameDeprecated => '${_scriptName}_output.json';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a @Deprecated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least a todo if you want to avoid the analysis errors

Copy link

auto-submit bot commented Jan 13, 2025

auto label is removed for dart-lang/native/1882, due to - The status or check suite dart-sdk-clang (ubuntu, stable, native_toolchain_c) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot merged commit 3832e4b into main Jan 13, 2025
57 checks passed
@auto-submit auto-submit bot deleted the output-file branch January 13, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants