-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_assets_cli] Add HookInput.outputFile
#1882
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
@@ -16,5 +16,5 @@ enum Hook { | |||
|
|||
String get scriptName => '$_scriptName.dart'; | |||
|
|||
String get outputName => '${_scriptName}_output.json'; | |||
String get outputNameDeprecated => '${_scriptName}_output.json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a @Deprecated
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or at least a todo if you want to avoid the analysis errors
auto label is removed for dart-lang/native/1882, due to - The status or check suite dart-sdk-clang (ubuntu, stable, native_toolchain_c) has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Pass in a path to where the
output.json
should be written.This enables the output file to not be written into the output directory but next to it. This is cleaner.
I don't remember where we discussed this, but some references to adding the output json can be found in the discussions here:
BuildConfig.targetOS
toBuildConfig.codeConfig.targetOS
, remove it entirely or extend to cover web #1738