Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in the warn if private log message. #824

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

rizerco
Copy link
Contributor

@rizerco rizerco commented Nov 23, 2023

The CLA should now be signed.

Copy link

google-cla bot commented Nov 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @rizerco!

Please sign the CLA so we can merge.

@coveralls
Copy link

Coverage Status

coverage: 92.711% (+0.04%) from 92.669%
when pulling 7d4a5dd on rizerco:main
into 9f29edc on dart-lang:main.

@rizerco
Copy link
Contributor Author

rizerco commented Nov 24, 2023

Thanks — I’ve signed the CLA but couldn’t see a way to rerun the checks?

@rizerco rizerco requested a review from dcharkes November 24, 2023 15:36
@dcharkes
Copy link
Collaborator

Thanks — I’ve signed the CLA but couldn’t see a way to rerun the checks?

I've hit rerun, all green now!

@dcharkes dcharkes merged commit 13b6b7e into dart-lang:main Nov 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants