Generate getters for static final strings
#825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/jnigen#400)" This reverts commit 8456a7c.
dcharkes
reviewed
Nov 24, 2023
| @@ -36,7 +36,8 @@ void registerTests(String groupName, TestRunnerCallback test) { | |||
| expect(Example.OFF, equals(0)); | |||
| expect(Example.PI, closeTo(pi, fpDelta)); | |||
| expect(Example.SEMICOLON, equals(';'.codeUnitAt(0))); | |||
| expect(Example.SEMICOLON_STRING, equals(';')); | |||
| expect(Example.SEMICOLON_STRING.toDartString(releaseOriginal: true), | |||
| equals(';')); | |||
There was a problem hiding this comment.
Add an emoji as well in pkgs/jnigen/test/simple_package_test/java/com/github/dart_lang/jnigen/simple_package/Example.java ?
Can we detect if we have emoji's? Should we consider having readable const strings in Dart for non-emoji strings? It is a better user experience if you can click to definition in Dart and see what the string is. If it's not easy to detect, then lgtm. |
dcharkes
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #792.
Strings with emojis behaved differently between POSIX and Windows and I failed to fix the summarizer in Windows, so I decided to revert the
JFinalStringchanges and simply use a normal getter.