Skip to content
This repository has been archived by the owner on Jan 14, 2025. It is now read-only.

Misc cleanup #115

Merged
merged 6 commits into from
Sep 13, 2021
Merged

Misc cleanup #115

merged 6 commits into from
Sep 13, 2021

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Sep 13, 2021

  • Change to package:lints
  • Fix dartdoc generation
  • Update README and package description

@mit-mit mit-mit requested a review from lrhn September 13, 2021 13:07
@google-cla google-cla bot added the cla: yes label Sep 13, 2021
Copy link
Member

@lrhn lrhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change neeeded, otherwise LGTM.

@@ -3,7 +3,13 @@
// BSD-style license that can be found in the LICENSE file.

/// A package configuration is a way to assign file paths to package URIs,
/// and vice-versa,
/// and vice-versa.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line needs a /// too, otherwise I'm not sure the documentation above is associated with the library.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@mit-mit mit-mit merged commit e78c1d6 into master Sep 13, 2021
@mit-mit mit-mit deleted the cleanup branch September 13, 2021 14:18
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants